Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

downgrade ubuntu in order to fix CI #35580

Merged
merged 1 commit into from
Dec 5, 2022
Merged

downgrade ubuntu in order to fix CI #35580

merged 1 commit into from
Dec 5, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Dec 3, 2022 •
edited
Loading

Signed-off-by: Simon L szaimen@e.mail.de
image

@szaimen
downgrade ubuntu in order to fix CI
7964b86 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen added the 2. developing Work in progress label Dec 3, 2022
@szaimen szaimen added this to the Nextcloud 26 milestone Dec 3, 2022
@szaimen szaimen marked this pull request as ready for review December 3, 2022 22:35
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 3, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Dec 3, 2022

/backport to stable25

@szaimen
Copy link
Contributor Author

szaimen commented Dec 3, 2022

/backport to stable24

@szaimen
Copy link
Contributor Author

szaimen commented Dec 3, 2022

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Dec 3, 2022

/backport to stable22

@szaimen szaimen requested a review from a team December 4, 2022 09:22
@skjnldsv
Copy link
Member

skjnldsv commented Dec 4, 2022

WHat's the context of this? :)

@szaimen
Copy link
Contributor Author

szaimen commented Dec 4, 2022

WHat's the context of this? :)

See the failing phpunit tests e.g. in #35547 and in other PRs. For further context see the engineering chat.

@nickvergessen
Copy link
Member

Refering to an internal chat is not the best documentation. Just summarize it here?
Should also do it in the workflow template repository

@MichaIng
Copy link
Member

MichaIng commented Dec 4, 2022

I'd be also interested about the reason why it fails on Ubuntu Jammy runners. But good to know that there is a workaround for the CI failures 👍.

@szaimen
Copy link
Contributor Author

szaimen commented Dec 5, 2022

I updated the description 👍

@blizzz blizzz merged commit 4196bf8 into master Dec 5, 2022
@blizzz blizzz deleted the enh/noid/fix-CI branch December 5, 2022 09:59
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Dec 5, 2022

/backport to stable25

@MichaIng
Copy link
Member

MichaIng commented Dec 5, 2022

Wouldn't it be better to apply the workaround in #32003 instead? However, doesn't matter so much, both can be a short-term workaround only. Looks like #25551 needs to be done not not force admins of recent distros, with server-side encryption enabled, to enable legacy OpenSSL ciphers.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Dec 5, 2022

/backport to stable25

This was referenced Dec 5, 2022
Merged
Merged
Merged
@szaimen
Copy link
Contributor Author

szaimen commented Dec 5, 2022

all backports done. Looks like the stable22 and below does not need this.

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

1 similar comment
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@blizzz blizzz blizzz approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
5 participants
@szaimen @skjnldsv @nickvergessen @MichaIng @blizzz