Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Set page title for each sidebar section through User management pages #35629

Merged
merged 1 commit into from
Dec 22, 2022
Merged

[stable25] Set page title for each sidebar section through User management pages #35629

merged 1 commit into from
Dec 22, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Dec 6, 2022 •
edited by JuliaKirschenheuter
Loading

  • ⚠️ This backport had conflicts and is incomplete

backport of #35249

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25.0.2 milestone Dec 6, 2022
@blizzz blizzz mentioned this pull request Dec 8, 2022
Merged
@blizzz
Copy link
Member

blizzz commented Dec 8, 2022

→ 25.0.3

conflicts, btw, @JuliaKirschenheuter

@JuliaKirschenheuter
Copy link
Contributor

/compile amend /

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Dec 14, 2022
@ChristophWurst ChristophWurst force-pushed the backport/35249/stable25 branch from e3b0c12 to 6048537 Compare December 14, 2022 08:29
@ChristophWurst
Copy link
Member

This backport had conflicts and is incomplete

https://github.com/nextcloud/server/pull/35249/files#diff-4344c8acccdab7720013dab609b5cd1917d16892d7d014df1a5674e3a90af6e5R100-R101 is missing

@ChristophWurst
Copy link
Member

Have you resolved the conflicts? If so, please check the checkbox above.

@ChristophWurst ChristophWurst added 2. developing Work in progress 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 21, 2022
@JuliaKirschenheuter
Adapt router.js for setting document title
8959504 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
PVince81
PVince81 approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

but shouldn't the PR title be "user management" pages ? I got confused and was looking at app management instead

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 22, 2022
@JuliaKirschenheuter JuliaKirschenheuter changed the title [stable25] Set page title for each sidebar section through App management pages [stable25] Set page title for each sidebar section through User management pages Dec 22, 2022
@PVince81 PVince81 merged commit e4199ad into stable25 Dec 22, 2022
@PVince81 PVince81 deleted the backport/35249/stable25 branch December 22, 2022 10:17
@skjnldsv skjnldsv mentioned this pull request Jan 6, 2023
Merged
5 tasks
@blizzz blizzz mentioned this pull request Jan 11, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@PVince81 PVince81 PVince81 approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@Pytal Pytal Awaiting requested review from Pytal

@st3iny st3iny Awaiting requested review from st3iny

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility bug
Projects
None yet
Milestone
Nextcloud 25.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@blizzz @JuliaKirschenheuter @ChristophWurst @PVince81