-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preview: fix HEIC orientation #35689
Conversation
/backport to stable25 |
This comment was marked as resolved.
This comment was marked as resolved.
@pulsejet if you want you have permissions to create branches here :) |
The rebase bot didn't have the permission to rebase your fork. |
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Ah, I see. I'll use branches henceforth; thanks for the heads up! |
c0b2184
to
7004c1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but didnt test
I do not get why those two tests are failing... 🙈
I think this is from the fork. No clue why, I will merge and see |
https://github.com/nextcloud/server/actions/runs/3668510626 EDIT: all good! No clue why the fork was failing |
/backport to stable24 |
iOS camera images previews are not correctly oriented with HEIC for portrait. This fixes the orientation. A sample image is attached (zip cause GitHub forbids HEIC).
Request: please backport to 25.
IMG_5820.zip