Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] Fix default primary for user theming #35702

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 9, 2022

Fix #35002

26 is fixed already

@skjnldsv skjnldsv added this to the Nextcloud 25.0.3 milestone Dec 9, 2022
@skjnldsv skjnldsv requested review from newhinton and a team December 9, 2022 07:14
@skjnldsv skjnldsv self-assigned this Dec 9, 2022
@skjnldsv skjnldsv requested review from PVince81, artonge and szaimen and removed request for a team December 9, 2022 07:14
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skjnldsv skjnldsv force-pushed the fix/theming-fallback-default branch from e739ced to 9949849 Compare December 13, 2022 08:35
@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 13, 2022

Fixed acceptance. They were previously wrongly adjusted to pass.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 13, 2022
@PVince81
Copy link
Member

conflict in the theming test

@skjnldsv
Copy link
Member Author

conflict in the theming test

resolved

@PVince81
Copy link
Member

@skjnldsv theming test in CI is failing, probably needs adjusting as well

skjnldsv and others added 2 commits December 21, 2022 15:13
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv
Copy link
Member Author

Fixed

@skjnldsv skjnldsv force-pushed the fix/theming-fallback-default branch from 6484e7b to 1888458 Compare December 21, 2022 14:18
@skjnldsv skjnldsv merged commit 20608fb into stable25 Dec 21, 2022
@skjnldsv skjnldsv deleted the fix/theming-fallback-default branch December 21, 2022 14:37
@skjnldsv skjnldsv mentioned this pull request Jan 6, 2023
5 tasks
@blizzz blizzz mentioned this pull request Jan 11, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants