Adding option to set Auto-Submitted email header #35876
Conversation
bennet0496
requested review from
CarlSchwan,
ChristophWurst,
miaulalala,
nickvergessen and
tcitworld
as code owners
szaimen
requested review from
a team,
PVince81 and
icewind1991
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
and implementation in OC\Mail\Message Signed-off-by: Bennet Becker <bbecker@pks.mpg.de>
Signed-off-by: Bennet Becker <bbecker@pks.mpg.de>
Signed-off-by: Bennet Becker <bbecker@pks.mpg.de>
Signed-off-by: Bennet Becker <bbecker@pks.mpg.de>
header Signed-off-by: Bennet Becker <bbecker@pks.mpg.de>
Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com> Signed-off-by: Bennet B <bennet0496@users.noreply.github.com>
Signed-off-by: Bennet Becker <dev@bennet.cc>
bennet0496
force-pushed
the
patch-mail-header
branch
from
21cd8d3 to
411467a
Compare
(was changed by autoloaderchecker.sh or composer?) Signed-off-by: Bennet Becker <dev@bennet.cc>
…e class" This reverts commit 77569ba. Signed-off-by: Bennet Becker <dev@bennet.cc>
|
which of the autoloader changes are ones that need to stay? If any, probably only |
Signed-off-by: Bennet Becker <dev@bennet.cc>
uses method from nextcloud/server#35876 if it exists, falling back setting it via the swift message Signed-off-by: Bennet Becker <dev@bennet.cc>
and then commit it. |
header name to constants Signed-off-by: Bennet Becker <dev@bennet.cc>
Signed-off-by: Bennet Becker <dev@bennet.cc>
apps/dav/lib/CalDAV/Reminder/NotificationProvider/EmailProvider.php
Outdated
Show resolved
Hide resolved
Signed-off-by: Bennet Becker <dev@bennet.cc>
Signed-off-by: Bennet Becker <dev@bennet.cc>
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Good stuff @bennet0496 |
|
thank you @nickvergessen it's always cool if I can help and contribute, even with the limited amount of coding I usually do 😄 |
ChristophWurst
added
the
pending documentation
|
hello @bennet0496 |
|
Short docs were added in #34692 (comment) |
|
All our emailing has no docs. |
nickvergessen
removed
the
pending documentation
uses method from nextcloud/server#35876 if it exists, falling back setting it via the swift message Signed-off-by: Bennet Becker <dev@bennet.cc>
uses method from nextcloud/server#35876 if it exists, falling back setting it via the swift message Signed-off-by: Bennet Becker <dev@bennet.cc>
uses method from nextcloud/server#35876 Signed-off-by: Bennet Becker <dev@bennet.cc>
Related to issue #16538 and PR #27200
As previously discussed an proposed in the issue and PR, this PR add the option Auto-Submitted, which has the main purpose of stopping properly configured mail server from sending OOO-Auto-Replys in response to fully automatic Nextcloud notifications. However as @nickvergessen mentioned in #27200 (comment) it might not be ideal to hard code the header for any email sent by Nextcloud, for this reason I added the method
setAutoSubmitted(string $value)toOC\Mail\Message, which allows apps to dynamically set this header if it is deemed appropriate. The current default is to not set the Header which is equivalent toAuto-Submitted: no. The set of valid values is available withOCP\Mail\AutoSubmittedValue.Additionally I set this Auto-Submitted value for new user welcome mail (
NewUserMailHelperinapps/settings) and CalDAV notifications (OCA\DAV\CalDAV\Reminder\NotificationProviderinapps/dav)The image show the header being adding to the new user mail, but not the test mail. I was not able to trigger a DAV notification in my 5min test installation until now, but as the code is the same I expect similar results.
Unit tests for the new methods are added as well.