Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom tooltips with native ones in users page #35893

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Replace custom tooltips with native ones in users page #35893

merged 1 commit into from
Jan 11, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Dec 27, 2022 •
edited
Loading

Signed-off-by: julia.kirschenheuter julia.kirschenheuter@nextcloud.com

Summary

Replace custom tooltips with native ones in users page

Checklist

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Dec 27, 2022
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Dec 27, 2022
ChristophWurst
ChristophWurst approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The disappearance of dist/icons.css raises suspicion

@ChristophWurst
Copy link
Member

TODO

  • Replace custom tooltips with native ones in users page

Check this once it's done.

@ChristophWurst
Copy link
Member

/backport to stable25

Pytal
Pytal approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the probably unintentional removal of dist/icons.css

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 10, 2023
@ChristophWurst
Copy link
Member

conflicts

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/35888-Replace_custom_tooltips_with_native_one_for_Users_page branch 2 times, most recently from 2e33ea8 to 95ee7c7 Compare January 10, 2023 13:40
@JuliaKirschenheuter
Replace custom tooltips with native ones in users page
1935828 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/35888-Replace_custom_tooltips_with_native_one_for_Users_page branch from 95ee7c7 to 1935828 Compare January 11, 2023 09:08
@JuliaKirschenheuter JuliaKirschenheuter merged commit 9bddc38 into master Jan 11, 2023
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/35888-Replace_custom_tooltips_with_native_one_for_Users_page branch January 11, 2023 12:05
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 11, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@Pytal Pytal Pytal approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@szaimen szaimen Awaiting requested review from szaimen

@artonge artonge Awaiting requested review from artonge

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility enhancement feature: users and groups
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BITV]: Replace custom tooltips with native one for Users page
3 participants
@JuliaKirschenheuter @ChristophWurst @Pytal