Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom tooltips with native tooltips in personal and administration settings #35901

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Replace custom tooltips with native tooltips in personal and administration settings #35901

merged 1 commit into from
Jan 11, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Dec 28, 2022 •
edited
Loading

Summary

Replace custom tooltips with native tooltips in personal and administration settings sections besides "Mobile & desktop", "Privacy" and "System"

Checklist

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Dec 28, 2022
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Dec 28, 2022
ChristophWurst
ChristophWurst approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The disappearance of dist/icons.css is suspicious once again

@ChristophWurst
Copy link
Member

/backport to stable25

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/35886-Replace_custom_tooltips_with_native_one_for_personal_and_administration_settings branch from 525cbb0 to e7d025b Compare January 10, 2023 08:35
@PVince81 PVince81 requested a review from Pytal January 10, 2023 15:01
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/35886-Replace_custom_tooltips_with_native_one_for_personal_and_administration_settings branch from e7d025b to 1b5b93e Compare January 10, 2023 16:26
@PVince81
Copy link
Member

@JuliaKirschenheuter please check handlebars failure

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/35886-Replace_custom_tooltips_with_native_one_for_personal_and_administration_settings branch from 1b5b93e to 3c74fcb Compare January 11, 2023 09:16
@JuliaKirschenheuter
Replace custom tooltips with native tooltips
087f445 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/35886-Replace_custom_tooltips_with_native_one_for_personal_and_administration_settings branch from 3c74fcb to 087f445 Compare January 11, 2023 13:23
@JuliaKirschenheuter JuliaKirschenheuter merged commit 8393ae2 into master Jan 11, 2023
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/35886-Replace_custom_tooltips_with_native_one_for_personal_and_administration_settings branch January 11, 2023 14:22
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable25

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@ChristophWurst
Copy link
Member

Time for https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Jan 17, 2023
Merged
2 tasks
@nickvergessen
Copy link
Member

  • Screenshots before/after for front-end changes

Wondering why there are frontend changes without screenshots. The template should help to remind you about them.

Here are the screenshots:

Before After
Bildschirmfoto vom 2023-01-17 22-08-38 Bildschirmfoto vom 2023-01-17 22-09-07

Can you fix that in a follow up? Thanks

@JuliaKirschenheuter
Copy link
Contributor Author

Can you fix that in a follow up? Thanks

Thank you! Of coarse i will fix it. As a follow-up

@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Jan 18, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@artonge artonge artonge approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@GretaD GretaD Awaiting requested review from GretaD

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BITV]: Replace custom tooltips with native one for personal and administration settings
7 participants
@JuliaKirschenheuter @ChristophWurst @PVince81 @nickvergessen @artonge @Pytal @skjnldsv