Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable24] Quota value as float for 32-bit systems #35940

Merged
merged 5 commits into from
Jan 3, 2023
Merged

[stable24] Quota value as float for 32-bit systems #35940

merged 5 commits into from
Jan 3, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jan 2, 2023 •
edited by come-nc
Loading

  • ⚠️ This backport had conflicts and is incomplete

backport of #35734

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 24.0.10 milestone Jan 2, 2023
@come-nc come-nc changed the title [stable24] [stable25] Quota value as float for 32-bit systems [stable24] Quota value as float for 32-bit systems Jan 2, 2023
PVince81 and others added 4 commits January 2, 2023 12:22
@PVince81 @come-nc
Remove quota value type for 32-bit systems
8239752 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@come-nc
Make it clear that file sizes may be float on 32bits
5421510 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Adapt types of subclasses
39cb354 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Silence a warning from psalm with explanation
602cc72 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the backport/35734/stable24 branch from 3adc0d2 to 602cc72 Compare January 2, 2023 11:24
@come-nc
Remove null from quota type
6def133 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added the 3. to review Waiting for reviews label Jan 2, 2023
@come-nc come-nc requested review from a team, ArtificialOwl, icewind1991 and blizzz and removed request for a team January 2, 2023 14:50
PVince81
PVince81 approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 00645c6 into stable24 Jan 3, 2023
@PVince81 PVince81 deleted the backport/35734/stable24 branch January 3, 2023 09:38
@skjnldsv skjnldsv mentioned this pull request Jan 6, 2023
Merged
8 tasks
@blizzz blizzz mentioned this pull request Jan 11, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@PVince81 PVince81 PVince81 approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@blizzz blizzz Awaiting requested review from blizzz blizzz was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: files
Projects
None yet
Milestone
Nextcloud 24.0.9
Development

Successfully merging this pull request may close these issues.
3 participants
@PVince81 @come-nc @blizzz