[stable25] chore(CI): Improve rate limit situation when installing phpunit #35962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
approved these changes
Jan 3, 2023
come-nc
reviewed
Jan 3, 2023
Comment on lines
+18
to
+31
| submodules: true | ||
|
|
||
| - name: Set up php | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: '8.0' | ||
| extensions: ctype,curl,dom,fileinfo,gd,intl,json,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip | ||
| coverage: none | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Composer install | ||
| run: composer i | ||
|
|
There was a problem hiding this comment.
This is not consistent with the use of docker://vimeo/psalm-github-actions:4.9.3 below which already has php and psalm
There was a problem hiding this comment.
(but in #34997 we are merging this file with the other one anyway)
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
backport/359577stable25
branch
from
30bfe80 to
4fb6f30
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Indent is wrong: FIXED |
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #35957