Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elaborate on what is required for using the tempdirectory setting of nextcloud #35974

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

CaptainSifff
Copy link
Contributor

This elaborates a bit on the tempdirectory setting of nextcloud and how to get it working.

Signed-off-by: Florian Goth fgoth@physik.uni-wuerzburg.de

Summary

TODO

  • Proofread

…nextcloud

Signed-off-by: Florian Goth <fgoth@physik.uni-wuerzburg.de>
@szaimen szaimen added this to the Nextcloud 26 milestone Jan 4, 2023
@szaimen szaimen added the 3. to review Waiting for reviews label Jan 4, 2023
@szaimen szaimen requested review from kesselb, a team, ArtificialOwl, icewind1991 and blizzz and removed request for a team January 4, 2023 00:24
config/config.sample.php Outdated Show resolved Hide resolved
Co-authored-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: CaptainSifff <CaptainSifff@gmx.de>
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had something different in mind, but fine by me.

@szaimen szaimen merged commit 9265463 into nextcloud:master Jan 4, 2023
@welcome
Copy link

welcome bot commented Jan 4, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@come-nc
Copy link
Contributor

come-nc commented Jun 15, 2023

I do not think this is true.
Setting the temp directory through environment var is not the same as setting it through tempdirectory config value.
The only requirement should be to allow php to write in the directory.

@CaptainSifff Can you explain this change?

@CaptainSifff
Copy link
Contributor Author

I tried setting the tempdirectory and expected this to be usable by nextcloud. As I found out the hard way, there are more prerequisites like the environment variables of PHP or the configuration of PHP. And beyond that there's apparmor and SELinux. And I wanted to point users to this so that they also check this.

@come-nc
Copy link
Contributor

come-nc commented Jun 19, 2023

I tried setting the tempdirectory and expected this to be usable by nextcloud. As I found out the hard way, there are more prerequisites like the environment variables of PHP or the configuration of PHP. And beyond that there's apparmor and SELinux. And I wanted to point users to this so that they also check this.

But it is not the same thing, if you set the env var you do not need to set tempdirectory config option from what I understand.

@CaptainSifff
Copy link
Contributor Author

I think I had to do both, as far as I recall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'tempdirectory' in config.php is ignored.
5 participants