Show local time in avatar menu #35979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
ArtificialOwl,
icewind1991 and
blizzz
and removed request for
a team
PVince81
reviewed
Jan 4, 2023
| if (!empty($targetUser)) { | ||
| $timezone = $this->config->getUserValue($targetUser->getUID(), 'core', 'timezone') ?: date_default_timezone_get(); | ||
| $dateTimeZone = new \DateTimeZone($timezone); | ||
| $localTime = $this->dateTimeFormatter->formatTime($this->timeFactory->getDateTime(), 'short', $dateTimeZone); |
There was a problem hiding this comment.
shouldn't this be a live view in the frontend instead ?
we'd need to expose the time zone info instead and compute the time in the frontend (possible with the "moment" library)
There was a problem hiding this comment.
I see that it's in the contacts menu, if the time is recomputed on every click on an avatar then it's accurate enough with the current solution
There was a problem hiding this comment.
if the time is recomputed on every click on an avatar
Exactly that is the case
There was a problem hiding this comment.
shouldn't this be a live view in the frontend instead ?
That would mean clients of the API would also need to do that. Would like to avoid it.
vitormattos
approved these changes
Jan 4, 2023
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
deleted the
feature/talk-4657/show-local-time-in-avatar-menu
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nextcloud/spreed#4657
Checklist