Improve saving applicable users in ext storage #36087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
added
enhancement
3. to review
PVince81
requested review from
icewind1991,
artonge,
skjnldsv,
Pytal and
szaimen
|
note: I chose this kind of interaction mostly for saving time there wasn't a way for select2 to have a special entry to say "All users" and I didn't want to dig there further or hack around because we want to stop using select2 eventually |
|
/backport to stable25 |
artonge
approved these changes
Jan 11, 2023
skjnldsv
approved these changes
Jan 11, 2023
Pytal
approved these changes
Jan 11, 2023
Added a checkbox to prevent saving "All users" by mistake and giving access to everyone when not wanted. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
force-pushed
the
enh/noid/improve-applicable-ext-storage
branch
from
5924293 to
4f35cd5
Compare
|
The backport to stable25 failed. Please do this backport manually. |
|
stable25: #36174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a checkbox to prevent saving "All users" by mistake and giving access to everyone when not wanted.
This was reported many times by surprised admins.
Sorry for the jQuery, this was not the right time to port the whole thing to Vue as it would blow up the required efforts.
Summary
This only touches the UI to add an additional safeguard to prevent saving the configuration when nothing was selected in the multiselect dropdown. In case "all users" is the intentional choice, the admin needs to tick a checkbox.
Otherwise it will not save.
Before
After
Checklist