Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PHP8.2): Fix deprecated string interpolation syntax #36162

Merged
merged 1 commit into from
Jan 19, 2023
Merged

fix(PHP8.2): Fix deprecated string interpolation syntax #36162

merged 1 commit into from
Jan 19, 2023

Conversation

ChristophWurst
Copy link
Member

  • Resolves: PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in nextcloud/core/Command/Maintenance/RepairShareOwnership.php on line 80

Summary

^

TODO

  • Do

Checklist

@ChristophWurst ChristophWurst added this to the Nextcloud 26 milestone Jan 16, 2023
@ChristophWurst ChristophWurst self-assigned this Jan 16, 2023
@ChristophWurst ChristophWurst mentioned this pull request Jan 16, 2023
Closed
19 tasks
@ChristophWurst ChristophWurst force-pushed the fix/php82/string-var-interpolation branch from 2e46ac8 to 1b8a52f Compare January 19, 2023 11:29
@ChristophWurst
fix(PHP8.2): Fix deprecated string interpolation syntax
2e66acf 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the fix/php82/string-var-interpolation branch from 1b8a52f to 2e66acf Compare January 19, 2023 12:10
vitormattos
vitormattos reviewed Jan 19, 2023
View reviewed changes
Copy link
Contributor

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe is a good point to put on the linter.

miaulalala
miaulalala approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 19, 2023
@ChristophWurst
Copy link
Member Author

one ci run failed at cloning -> 🐘

@ChristophWurst ChristophWurst merged commit d42d8b7 into master Jan 19, 2023
@ChristophWurst ChristophWurst deleted the fix/php82/string-var-interpolation branch January 19, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitormattos vitormattos vitormattos approved these changes

@come-nc come-nc come-nc approved these changes

@miaulalala miaulalala miaulalala approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@kesselb kesselb Awaiting requested review from kesselb

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristophWurst @vitormattos @miaulalala @come-nc