chore: drop dependency php-ds #36198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
force-pushed
the
3rdparty-remove-ds
branch
from
d1e766e
to
fbfc428
Compare
nickvergessen
force-pushed
the
3rdparty-remove-ds
branch
from
fbfc428
to
d152d43
Compare
The dependency is not used. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de> Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
3rdparty-remove-ds
branch
from
d152d43
to
de5fb80
Compare
nickvergessen
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The dependency is not used.
I think the polyfill was slow or incomplete and it was decided to not use it.
TODO
Checklist