Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] fix(dav): catch MaxInstancesExceededException for recurring events without end date #36230

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #36211

…hout end date

Ref nextcloud/calendar#4811

Signed-off-by: Anna Larch <anna@nextcloud.com>
'id' => $reminder['object_id'],
], $reminder['event_hash'], $alarmHash, true, false);
$this->writeRemindersToDatabase($alarms);
foreach ($event->VALARM as $valarm) {

Check notice

Code scanning / Psalm

PossiblyNullIterator

Cannot iterate over nullable var Sabre\VObject\Property|null
@miaulalala
Copy link
Contributor

miaulalala commented Jan 23, 2023

Drone failures are:

/drone/src/tests/acceptance/features/app-files-sharing-link.feature:26
/drone/src/tests/acceptance/features/app-files-sharing.feature:376

I don't think this is related

@come-nc come-nc merged commit b848f70 into stable25 Jan 26, 2023
@come-nc come-nc deleted the backport/36211/stable25 branch January 26, 2023 13:11
@blizzz blizzz mentioned this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature: caldav Related to CalDAV internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants