-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3rdparty/symfony/translation #36505
Closed
Closed
3rdparty/symfony/translation #36505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature freeze, try again when stable 26 is branched off end of the month 😅 |
Please rebase @vitormattos |
vitormattos
force-pushed
the
3rdparty/symfony/translation
branch
from
March 22, 2023 12:35
08ca3b6
to
54ab0c3
Compare
@come-nc rebased. |
vitormattos
force-pushed
the
3rdparty/symfony/translation
branch
from
March 22, 2023 14:14
54ab0c3
to
324490c
Compare
Was changed at the newest version of symfony/translation Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattos
force-pushed
the
3rdparty/symfony/translation
branch
from
March 23, 2023 09:12
324490c
to
09eea2a
Compare
come-nc
approved these changes
Mar 27, 2023
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Replaced by nextcloud/3rdparty#1482 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump symfony/translation
Ref: nextcloud/3rdparty#1304
Close nextcloud/3rdparty#922
The original PR from dependabot used an old version of translation package. I created a new PR with the newest version of package compatible with PHP 8.0.
The class
TranslatorInterface
that I removed from comment was removed from Translation package.