Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OCM validation errors #36667

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Fix OCM validation errors #36667

merged 1 commit into from
Mar 29, 2023

Conversation

provokateurin
Copy link
Member

Summary

According to the spec the validationErrors is an array of objects.

Checklist

@provokateurin provokateurin mentioned this pull request Feb 10, 2023
8 tasks
@provokateurin provokateurin force-pushed the fix/ocm-validation-errors branch from 1ac359d to 0e62028 Compare February 10, 2023 21:55
Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin provokateurin force-pushed the fix/ocm-validation-errors branch from 0e62028 to b271096 Compare February 10, 2023 21:56
@szaimen szaimen added this to the Nextcloud 26 milestone Feb 11, 2023
@szaimen szaimen added the 3. to review Waiting for reviews label Feb 11, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 7, 2023
@provokateurin provokateurin requested a review from julien-nc March 17, 2023 10:25
@provokateurin
Copy link
Member Author

Technically this should be backported to every version, since it's a non-compliant implementation of the spec, but so far nobody complained, so it's probably not a big deal anyway, right?

@provokateurin provokateurin merged commit fc371fa into master Mar 29, 2023
@provokateurin provokateurin deleted the fix/ocm-validation-errors branch March 29, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants