-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change X-Robots-Tag header from "none" to "noindex, nofollow" #36689
Conversation
/backport to stable25 |
/backport to stable24 |
78d6908
to
ad2c43b
Compare
This btw means that all admin, who did not have a warning before, do now see it, until their
|
Actually the .htaccesss is delivered with the Nextcloud archive so it should usually be overwritten with the new one upon updating. |
The bottom section is however a custom one and preserved on update, so it is not just replaced. I actually never check whether the top section is updated. |
It is not preserved upon update IIRC. |
It is, or otherwise |
I see. I thought the file would always get updated since it must have the latest changes... |
Quite possible (and would be reasonable) if the bottom section of the old |
- DietPi-Software | Change X-Robots-Tag header from "none" to "noindex, nofollow": nextcloud/server#36689
Not my area of expertise, so removing my review as I'm overloaded at the moment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an expert here either but looks good
Nginx doc should definitely be updated and this needs to be mentioned in the admin doc changes of 27
The This means Apache users with |
Integration test failures do not seem to be related:
|
For reference: nextcloud/server#36689 Signed-off-by: MichaIng <micha@dietpi.com>
For reference: nextcloud/server#36689 Signed-off-by: MichaIng <micha@dietpi.com>
CI failure unrelated |
hello @MichaIng |
Hi Daphne, the documentation change has been merged already, so not pending anymore: nextcloud/documentation#9635 |
thank you for your lightning fast reply and for removing the pending documentation label @MichaIng !❤️ |
Upstream did so in nextcloud/server#36689 and Nextcloud now complains that The "X-Robots-Tag" HTTP header is not set to "noindex, nofollow". This is a potential security or privacy risk, as it is recommended to adjust this setting accordingly.
Upstream did so in nextcloud/server#36689 and Nextcloud now complains that The "X-Robots-Tag" HTTP header is not set to "noindex, nofollow". This is a potential security or privacy risk, as it is recommended to adjust this setting accordingly. (cherry picked from commit 15b859c)
Summary
While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#other_metadata_names https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag?hl=de#comma-separated-list https://www.bing.com/webmasters/help/which-robots-metatags-does-bing-support-5198d240
TODO
Checklist