Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add label and switch ocdialog close button to button element #36772

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Add label and switch ocdialog close button to button element #36772

merged 1 commit into from
Mar 7, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Feb 18, 2023 •
edited
Loading

Summary

Before After
image image

Without a label screenreader users cannot identify the interactive element

Checklist

@Pytal Pytal added this to the Nextcloud 26 milestone Feb 18, 2023
@Pytal Pytal self-assigned this Feb 18, 2023
@Pytal
Copy link
Member Author

Pytal commented Feb 18, 2023

/backport to stable25

@Pytal Pytal mentioned this pull request Feb 18, 2023
Closed
4 tasks
szaimen
szaimen approved these changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@Pytal Pytal force-pushed the enh/a11y-ocdialog-close branch from 28b6889 to 873a502 Compare February 22, 2023 02:26
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
JuliaKirschenheuter
JuliaKirschenheuter requested changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see the comment from @artonge

@Pytal Pytal force-pushed the enh/a11y-ocdialog-close branch from 873a502 to e91ec29 Compare March 3, 2023 21:51
@JuliaKirschenheuter
Copy link
Contributor

/backport to stable26

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Mar 6, 2023
@Pytal Pytal force-pushed the enh/a11y-ocdialog-close branch from 2f2f11e to d60b922 Compare March 6, 2023 19:10
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 6, 2023
@Pytal
Add label and switch ocdialog close button to button element
864fb3f 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/a11y-ocdialog-close branch from d60b922 to 864fb3f Compare March 6, 2023 20:56
@Pytal Pytal merged commit 24d4fa9 into master Mar 7, 2023
@Pytal Pytal deleted the enh/a11y-ocdialog-close branch March 7, 2023 00:37
This was referenced Mar 7, 2023
Merged
Merged
@danxuliu danxuliu mentioned this pull request May 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@artonge artonge artonge approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility feature: filepicker
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @JuliaKirschenheuter @artonge @szaimen