fix(SystemTagManager): Truncate overlong tag names #36837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
requested changes
Feb 24, 2023
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
force-pushed
the
fix/truncate-overlong-tagnames
branch
from
b124cd0 to
8151b1b
Compare
nickvergessen
requested changes
Feb 24, 2023
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
|
Do we backport this? |
nickvergessen
approved these changes
Feb 24, 2023
come-nc
approved these changes
Feb 27, 2023
I guess we could as it's not breaking things that worked before? |
|
Great! |
|
/backport to stable25 |
|
/backport to stable24 |
|
The backport to stable25 failed. Please do this backport manually. |
|
The backport to stable24 failed. Please do this backport manually. |
This was referenced Feb 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The systemtag.name column has a length of 64 but the code never asserts the length of tag names. Thus without this patch you can get an exception when creating tags with long names.
Checklist