-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure to never trigger files hooks on a null path #36893
Conversation
|
Thank you so much for the fix. I am really needing this fix because of issues with syncing bigger files. |
/rebase |
8843759
to
1021d03
Compare
/rebase |
1021d03
to
52902ef
Compare
/rebase |
Apologies for my lack of experience with GitHub and NC development, but will this only be pushed into Nextcloud 27 and not in a 26.0.x patch? |
Yes this will first be pushed into Nextcloud 27 and might then be backported to 26.0.x. |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
52902ef
to
6034cc6
Compare
@come-nc OK to be backported? |
Hum yeah psalm will complain about the backports I think because typing was hell, but let’s try it. |
/backport to stable26 |
/backport to stable25 |
strpos()
and/orpathinfo()
: Passing null to parameter #1 ($haystack) of type string is deprecated #34932Summary
File pre/post operation events should only be triggered for files inside the default view.
For other files a bogus event with a null path was fired, this avoids that.
Checklist