Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to never trigger files hooks on a null path #36893

Merged
merged 1 commit into from
May 9, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Feb 28, 2023

Summary

File pre/post operation events should only be triggered for files inside the default view.
For other files a bogus event with a null path was fired, this avoids that.

Checklist

@come-nc come-nc added the 2. developing Work in progress label Feb 28, 2023
@come-nc come-nc self-assigned this Feb 28, 2023
@come-nc come-nc added this to the Nextcloud 27 milestone Feb 28, 2023
@come-nc come-nc added the bug label Feb 28, 2023
@come-nc
Copy link
Contributor Author

come-nc commented Feb 28, 2023

@tram98
Copy link

tram98 commented Mar 4, 2023

Thank you so much for the fix. I am really needing this fix because of issues with syncing bigger files.

@come-nc
Copy link
Contributor Author

come-nc commented Apr 5, 2023

/rebase

@nextcloud-command nextcloud-command force-pushed the fix/avoid-file-events-on-null-path branch from 8843759 to 1021d03 Compare April 5, 2023 10:11
@come-nc come-nc marked this pull request as ready for review April 24, 2023 13:00
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 24, 2023
@come-nc come-nc requested review from a team, ArtificialOwl, icewind1991 and blizzz and removed request for a team April 24, 2023 13:01
@come-nc
Copy link
Contributor Author

come-nc commented May 2, 2023

/rebase

@come-nc come-nc requested review from susnux and artonge and removed request for blizzz May 2, 2023 16:02
@nextcloud-command nextcloud-command force-pushed the fix/avoid-file-events-on-null-path branch from 1021d03 to 52902ef Compare May 2, 2023 16:59
@skjnldsv skjnldsv mentioned this pull request May 3, 2023
@come-nc
Copy link
Contributor Author

come-nc commented May 4, 2023

/rebase

@dinosmm
Copy link

dinosmm commented May 4, 2023

Apologies for my lack of experience with GitHub and NC development, but will this only be pushed into Nextcloud 27 and not in a 26.0.x patch?

@susnux
Copy link
Contributor

susnux commented May 4, 2023

will this only be pushed into Nextcloud 27 and not in a 26.0.x patch?

Yes this will first be pushed into Nextcloud 27 and might then be backported to 26.0.x.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@nextcloud-command nextcloud-command force-pushed the fix/avoid-file-events-on-null-path branch from 52902ef to 6034cc6 Compare May 4, 2023 17:55
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 4, 2023
This was referenced May 9, 2023
@come-nc come-nc merged commit 185fe53 into master May 9, 2023
@come-nc come-nc deleted the fix/avoid-file-events-on-null-path branch May 9, 2023 15:44
@solracsf
Copy link
Member

solracsf commented May 9, 2023

@come-nc OK to be backported?

@come-nc
Copy link
Contributor Author

come-nc commented May 11, 2023

Hum yeah psalm will complain about the backports I think because typing was hell, but let’s try it.

@come-nc
Copy link
Contributor Author

come-nc commented May 11, 2023

/backport to stable26

@come-nc
Copy link
Contributor Author

come-nc commented May 11, 2023

/backport to stable25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: strpos() and/or pathinfo(): Passing null to parameter #1 ($haystack) of type string is deprecated
8 participants