Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chunking in SystemTagObjectMapper::getTagIdsForObjects #37029

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Mar 3, 2023

Summary

This avoids crashing on Oracle with more than 1000 objects

Checklist

@come-nc come-nc added the 3. to review Waiting for reviews label Mar 3, 2023
@come-nc come-nc added this to the Nextcloud 27 milestone Mar 3, 2023
@come-nc come-nc self-assigned this Mar 3, 2023
@come-nc
Copy link
Contributor Author

come-nc commented Mar 3, 2023

/backport to 26

@come-nc
Copy link
Contributor Author

come-nc commented Mar 3, 2023

/backport to 25

@come-nc
Copy link
Contributor Author

come-nc commented Mar 3, 2023

/backport to 24

@come-nc come-nc requested review from nickvergessen, vitormattos, a team, ArtificialOwl, icewind1991 and blizzz and removed request for a team March 3, 2023 09:48
@come-nc
Copy link
Contributor Author

come-nc commented Mar 13, 2023

/rebase

This avoids crashing on Oracle with more than 1000 objects

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@nextcloud-command nextcloud-command force-pushed the fix/chunk-objectids-in-systemtagobjectmapper branch from ef9c1f5 to 9b1d779 Compare March 13, 2023 17:36
@come-nc come-nc merged commit 7132810 into master Mar 13, 2023
@come-nc come-nc deleted the fix/chunk-objectids-in-systemtagobjectmapper branch March 13, 2023 21:10
@backportbot-nextcloud
Copy link

The backport to 24 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to 25 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to 26 failed. Please do this backport manually.

@come-nc
Copy link
Contributor Author

come-nc commented Mar 14, 2023

/backport to 26

@backportbot-nextcloud
Copy link

The backport to 26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout 26
git pull origin/26

# Create the new backport branch
git checkout -b fix/foo-26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@come-nc
Copy link
Contributor Author

come-nc commented Mar 14, 2023

/backport to stable26

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@come-nc
Copy link
Contributor Author

come-nc commented Mar 14, 2023

/backport to stable25

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export fails in CLI, Never finishes in GUI
3 participants