Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set <h1> headings for navigation through files app #37174

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Set <h1> headings for navigation through files app #37174

merged 1 commit into from
Mar 16, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Mar 10, 2023 •
edited
Loading

For current PR backport to stable25 are not needed. There will be another PR for NC25 because of different code structure

Summary

Until now there were no headings for navigation pages. Correct <h1> headings are important for accessibility.

After (no visible changes):

Screenshot from 2023-03-10 17-38-13

Checklist

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Mar 10, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Mar 10, 2023
@JuliaKirschenheuter
Copy link
Contributor Author

conflicts will be resolved after approve

@JuliaKirschenheuter
Copy link
Contributor Author

/backport to stable26

@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Mar 15, 2023
Closed
3 tasks
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36911-create-h1-heading-for-files branch from 40bda01 to 520b045 Compare March 16, 2023 09:16
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 16, 2023
@ChristophWurst ChristophWurst removed their request for review March 16, 2023 10:40
@JuliaKirschenheuter
Set <h1> headings for navigation through files app
058f7f4 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36911-create-h1-heading-for-files branch from 520b045 to 058f7f4 Compare March 16, 2023 10:51
@JuliaKirschenheuter JuliaKirschenheuter merged commit 961a1c8 into master Mar 16, 2023
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/36911-create-h1-heading-for-files branch March 16, 2023 13:19
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 16, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
No milestone
5 participants
@JuliaKirschenheuter @artonge @skjnldsv @Pytal @ChristophWurst