Move admin_audit hooks to proper event listeners #37193
Conversation
tcitworld
requested review from
ChristophWurst,
juliusknorr,
come-nc,
a team,
ArtificialOwl and
blizzz
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
tcitworld
force-pushed
the
admin_audit/enh/move-to-event-listeners
branch
2 times, most recently
from
921aa53 to
82b9461
Compare
|
See #32128 as well |
|
Is that different/better than #32019 ? |
|
I missed this one, thanks. 🙈 Well, there's more stuff in mine. I'll simply take the LDAP stuff from Carl's PR, and take over #32018 as well. |
tcitworld
force-pushed
the
admin_audit/enh/move-to-event-listeners
branch
from
82b9461 to
3fb14cc
Compare
tcitworld
force-pushed
the
admin_audit/enh/move-to-event-listeners
branch
2 times, most recently
from
01e64ac to
b543f31
Compare
|
|
||
| $params = [ | ||
| 'itemType' => $share->getNodeType(), | ||
| 'path' => $share->getNode()->getPath(), |
There was a problem hiding this comment.
question: Unfortunately, this makes extra calls to get the Node. Should the share or the event hold this information?
There was a problem hiding this comment.
Extra PHP calls? Or extra database queries?
Does not seem that overkill to me.
|
|
||
| $params = [ | ||
| 'itemType' => $share->getNodeType(), | ||
| 'path' => $share->getNode()->getPath(), |
There was a problem hiding this comment.
Extra PHP calls? Or extra database queries?
Does not seem that overkill to me.
|
Please strict type the hell out of this, return types on all new methods and strict_type declare on all new files, otherwise nice cleanup! |
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
…epreciated ConsoleEvent event Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
force-pushed
the
admin_audit/enh/move-to-event-listeners
branch
from
b543f31 to
52a289c
Compare
Based on work from #32019 Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
|
@tcitworld Can I take over this one? |
|
Yes please, I don't even want to have a look at the conflicts! 🙈 |
|
Supplanted by #47865 |
Requires #35677
Summary
Moves all of the hooks used by
admin_auditto event listeners, where appropriate typed events already exist.ConsoleEventV2typed event to replace the legacyConsoleEventevent in OCP (already depreciated). However, this doesn't seem used anywhere else, so we could replace it straight away.BeforePreviewFetchedEventeventPart of #14552. Follow #37194 to track all of the hooks left.
TODO
Checklist