Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Clear-Site-Data header and let browsers ignore it if unsupported #37405

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Send Clear-Site-Data header and let browsers ignore it if unsupported #37405

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfd7a57
Send header to all browsers under HTTPS
solracsf Mar 25, 2023
346054f
Fix tests
solracsf Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/Controller/LoginController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
*/
namespace OC\Core\Controller;

use OC\AppFramework\Http\Request;
use OC\Authentication\Login\Chain;
use OC\Authentication\Login\LoginData;
use OC\Authentication\WebAuthn\Manager as WebAuthnManager;
Expand Down Expand Up @@ -125,7 +124,8 @@ public function logout() {
$this->session->set('clearingExecutionContexts', '1');
$this->session->close();

if (!$this->request->isUserAgent([Request::USER_AGENT_CHROME, Request::USER_AGENT_ANDROID_MOBILE_CHROME])) {
if ($this->request->getServerProtocol() === 'https') {
// This feature is available only in secure contexts
$response->addHeader('Clear-Site-Data', '"cache", "storage"');
}

Expand Down