Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version number in phpdoc for app loading refactor #37425

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Mar 27, 2023

Checklist

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added enhancement 3. to review Waiting for reviews labels Mar 27, 2023
@come-nc come-nc added this to the Nextcloud 27 milestone Mar 27, 2023
@come-nc come-nc self-assigned this Mar 27, 2023
@come-nc come-nc added the pending documentation This pull request needs an associated documentation update label Mar 27, 2023
@come-nc
Copy link
Contributor Author

come-nc commented Mar 27, 2023

Pending documentation in #37039

@juliusknorr juliusknorr merged commit 5e7e3eb into master Mar 30, 2023
@juliusknorr juliusknorr deleted the fix/fix-since-version-number-for-app-loading branch March 30, 2023 12:20
@DaphneMuller
Copy link

Hello!
Thank you for your work on this! I noticed that your PR still has the label 'documentation'. I'm not sure if you already had a look at the documentation for your PR, but at Nextcloud we strive to document changes that affect other app developers or other admins before the release takes place, and I'm pinging you with the hope to get this done.

Are you familiar with our documentation process already?
Changes that affect app developers should be documented here:
https://docs.nextcloud.com/server/27/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_27.html

Changes that affect administrators should be documented here:
https://docs.nextcloud.com/server/latest/admin_manual/release_notes/upgrade_to_27.html

While I understand sometimes it's handy to merge fast to get your changes in, it would be great if next time you could try to add the documentation before merging. You can find more information on that here:
https://docs.nextcloud.com/server/27/developer_manual/prologue/compatibility_app_ecosystem.html#documentation-procedures-of-changes-that-affect-app-developers

If all your documentation efforts are done, please remove the label 'documentation' and check the checkbox in your opening note and I'll stop bugging you :)

Many thanks in advance and thanks again for your work!

@come-nc come-nc removed the pending documentation This pull request needs an associated documentation update label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants