Add missing interface methods #37452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
fix/missing-interface-methods
branch
2 times, most recently
from
4d5b9d9 to
4db16fb
Compare
nickvergessen
previously requested changes
Mar 28, 2023
provokateurin
force-pushed
the
fix/missing-interface-methods
branch
from
4db16fb to
1503756
Compare
provokateurin
requested review from
ChristophWurst and
tcitworld
as code owners
provokateurin
force-pushed
the
fix/missing-interface-methods
branch
from
1503756 to
140c409
Compare
provokateurin
requested review from
nickvergessen and
julien-nc
and removed request for
nickvergessen
julien-nc
approved these changes
Mar 30, 2023
|
The test failure isn't related, right? |
Signed-off-by: jld3103 <jld3103yt@gmail.com>
provokateurin
force-pushed
the
fix/missing-interface-methods
branch
from
140c409 to
02f9c3a
Compare
ChristophWurst
added
the
4. to release
|
If Php comments could break Cypress tests...I would be devastated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Psalm 5 shows a bunch of errors because of missing interface methods. Those methods are not on the interfaces because they should not be used by apps, but are used internally. Typing the variables as the implementation makes it work.
Checklist