-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix damaged UI userlist #37477
Fix damaged UI userlist #37477
Conversation
@szaimen if you triage a PR and request a review from engineers please make sure the PR is in a reviewable state. To judge the changes here we'd need a description or a linked ticket and before/after screenshots for the visual change. Cheers. |
Hi @szaimen and @ChristophWurst, Here are the requested and hopefully sufficient infos for you to acknowledge the changes: Bug report reference: Screenshots before and after the changes as attachment. Please let me know if something is missing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @inet-cologne for fixing this issue!
Not tested but looks good!
This comment was marked as resolved.
This comment was marked as resolved.
…uto-rows:minmax(60px, max-content) to grid-auto-rows:minmax(max-content, max-content). Signed-off-by: Chris <inet.cologne@gmail.com>
a9c171f
to
9f330d8
Compare
/compile amend / |
@inet-cologne please compile and ship changed dist files :) |
So basically please rebase, run npm ci and npm run bild and commit the changed files here. Thanks in advance! :) |
/rebase |
Hi there, Unfortunately the change was not merged in the follower versions of Nextcloud and the rebase produced now a merge conflict. Everything was documented in the related PR. Perhaps someone can assist in resolving the conflict please. |
As said above. |
Hey @inet-cologne after seeing the few issues we had with the user list, it received a refresh which makes your fix not required anymore! 😉 Thanks for taking the time to create this PR and help Nextcloud, and my apologies for taking this long to update this ticket 🙇 |
Summary
Fix CSS for user list backend to dont overlap entries - from grid-auto-rows:minmax(60px, max-content) to grid-auto-rows:minmax(max-content, max-content).
Checklist