Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the value of the "max-parts" parameter of the object storage 'ListPart' interface to 1000 #37534

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

Rsplwe
Copy link
Contributor

@Rsplwe Rsplwe commented Apr 1, 2023

Summary

Adjust the 'max-parts' parameter of the List Parts interface in the object storage to 1000 to solve the compatibility issue of Tencent Cloud object storage.

According to the documentation, Tencent Cloud Object Storage (COS) does not support calls to the max parts parameter of the ListPart interface for values greater than 1000.

Error Log

Aws\S3\Exception\S3Exception: Error executing "ListParts" on "https://cloud-xxx.cos.ap-xxx.myqcloud.com/xxxxxxxxxxxxxx&max-parts=10000"; AWS HTTP error: Client error: GET https://cloud-xxx.cos.ap-xxx.myqcloud.com/xxxxxxxxxxxxxx&max-parts=10000 resulted in a 400 Bad Request response: InvalidArgument The parameter max-parts is not v (truncated...) InvalidArgument (client): The parameter max-parts is not valid - InvalidArgument The parameter max-parts is not valid /urn:xxxx xxxxxxxxxxxxxxxxxxxxxxxxxxxx xxxxxxxxxxxxxxxxxxxxxxxxxxxx

Checklist

Signed-off-by: Rsplwe <i@rsplwe.com>
@szaimen szaimen requested review from juliusknorr, a team, ArtificialOwl, icewind1991 and come-nc and removed request for a team April 1, 2023 13:44
@szaimen szaimen added the 3. to review Waiting for reviews label Apr 1, 2023
@szaimen szaimen added this to the Nextcloud 27 milestone Apr 1, 2023
@Rsplwe Rsplwe changed the title Adjust the value of 'maxparts' to 1000 Adjust the value of the "max-parts" interface of the object storage 'ListPart' to 1000 Apr 1, 2023
@Rsplwe Rsplwe changed the title Adjust the value of the "max-parts" interface of the object storage 'ListPart' to 1000 Adjust the value of the "max-parts" parameter of the object storage 'ListPart' interface to 1000 Apr 1, 2023
Signed-off-by: Rsplwe <i@rsplwe.com>
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for the PR.

@juliusknorr juliusknorr added the bug label Apr 3, 2023
@juliusknorr
Copy link
Member

/backport to stable26

@juliusknorr
Copy link
Member

Performance testing failure is unrelated

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Rsplwe <i@rsplwe.com>
@szaimen szaimen enabled auto-merge April 17, 2023 21:34
@szaimen szaimen modified the milestones: Nextcloud 27, Nextcloud 28 Apr 17, 2023
@szaimen szaimen merged commit 45a0fe4 into nextcloud:master Apr 17, 2023
@welcome
Copy link

welcome bot commented Apr 17, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants