-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust the value of the "max-parts" parameter of the object storage 'ListPart' interface to 1000 #37534
Conversation
Signed-off-by: Rsplwe <i@rsplwe.com>
Signed-off-by: Rsplwe <i@rsplwe.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks for the PR.
/backport to stable26 |
Performance testing failure is unrelated |
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Rsplwe <i@rsplwe.com>
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Summary
Adjust the 'max-parts' parameter of the List Parts interface in the object storage to 1000 to solve the compatibility issue of Tencent Cloud object storage.
According to the documentation, Tencent Cloud Object Storage (COS) does not support calls to the max parts parameter of the ListPart interface for values greater than 1000.
Error Log
Aws\S3\Exception\S3Exception: Error executing "ListParts" on "https://cloud-xxx.cos.ap-xxx.myqcloud.com/xxxxxxxxxxxxxx&max-parts=10000"; AWS HTTP error: Client error:
GET https://cloud-xxx.cos.ap-xxx.myqcloud.com/xxxxxxxxxxxxxx&max-parts=10000
resulted in a400 Bad Request
response:InvalidArgument
The parameter max-parts is not v (truncated...) InvalidArgument (client): The parameter max-parts is not valid -InvalidArgument
The parameter max-parts is not valid /urn:xxxx xxxxxxxxxxxxxxxxxxxxxxxxxxxx xxxxxxxxxxxxxxxxxxxxxxxxxxxxChecklist