-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(security): Allow to opt-out of ratelimit protection, e.g. for te… #37542
Merged
nickvergessen
merged 1 commit into
master
from
bugfix/noid/allow-to-opt-out-of-ratelimit-for-testing
Apr 3, 2023
Merged
feat(security): Allow to opt-out of ratelimit protection, e.g. for te… #37542
nickvergessen
merged 1 commit into
master
from
bugfix/noid/allow-to-opt-out-of-ratelimit-for-testing
Apr 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
Apr 3, 2023
juliusknorr
reviewed
Apr 3, 2023
juliusknorr
approved these changes
Apr 3, 2023
…sting on CI Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/allow-to-opt-out-of-ratelimit-for-testing
branch
from
April 3, 2023 07:06
74c6ae9
to
454281a
Compare
/backport to stable26 |
/backport to stable25 |
/backport to stable24 |
/backport to stable23 |
/backport to stable22 |
nickvergessen
deleted the
bugfix/noid/allow-to-opt-out-of-ratelimit-for-testing
branch
April 3, 2023 12:19
5 tasks
This was referenced Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sting on CI
Summary
On talk integration tests are red on CI since middle of last week (Merge of #37497 ). Turns out it's the rate limiting hitting in disallowing to set the user's display name. See nextcloud/spreed#9233 for debugging history.
Checklist