Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Hides hidden files an folder in grid view #37599

Closed
wants to merge 2 commits into from

Conversation

Jerome-Herbinet
Copy link
Member

Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com

Summary

Hides hidden files an folder in grid view (replace calls to ".hidden" by ".hidden-file" class)

TODO

  • ...

Checklist

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>

Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@szaimen szaimen added this to the Nextcloud 27 milestone Apr 5, 2023
@szaimen szaimen added the 3. to review Waiting for reviews label Apr 5, 2023
@szaimen szaimen requested review from miaulalala, a team, artonge, Pytal and szaimen and removed request for a team April 5, 2023 12:09
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder wasnt this fixed with #37269?

@Jerome-Herbinet
Copy link
Member Author

I wonder wasnt this fixed with #37269?

@szaimen I use NC 25.0.5 and the problem still occurs. So, #37269 and/or #37287 don't solve the issue in the case I describe, or it's not solving the same problem.

@szaimen
Copy link
Contributor

szaimen commented Apr 5, 2023

@szaimen I use NC 25.0.5 and the problem still occurs. So, #37269 and/or #37287 don't solve the issue in the case I describe, or it's not solving the same problem.

Did you already try to clear the browser cache?

@Jerome-Herbinet
Copy link
Member Author

@szaimen I use NC 25.0.5 and the problem still occurs. So, #37269 and/or #37287 don't solve the issue in the case I describe, or it's not solving the same problem.

Did you already try to clear the browser cache?

Yes I did.

@szaimen
Copy link
Contributor

szaimen commented Apr 5, 2023

Yes I did.

Apparently #37287 will be included in 25.0.6.

@Jerome-Herbinet
Copy link
Member Author

OK, do I close this PR now, or do we wait for NC 25.0.6 to do it ? (after checking front-end behaviour) ?

@szaimen
Copy link
Contributor

szaimen commented Apr 5, 2023

I'd wait for 25.0.6 and 26.0.1 first

This was referenced May 3, 2023
@blizzz blizzz mentioned this pull request May 17, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv
Copy link
Member

Fixed with 28 and above

@skjnldsv skjnldsv closed this Feb 23, 2024
@skjnldsv skjnldsv removed the 3. to review Waiting for reviews label Feb 23, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 29 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants