New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SpeechToText): Add SpeechToText OCP provider API #37674

Merged

nickvergessen merged 26 commits into master from feature/speech-to-text

Apr 19, 2023

Member

marcelklehr commented Apr 11, 2023 •

edited

Loading

Summary

Implement an OCP API register and call SpeechToText providers

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required: feat(SpeechToText): Add developer docs for OCP\SpeechToText documentation#10085
Backports requested where applicable (ex: critical bugfixes)

marcelklehr added 3 commits

April 11, 2023 14:59


          feat(SpeechToText): Add SpeechToText provider API

317521b

Signed-off-by: Marcel Klehr <mklehr@gmx.net>


          feat(SpeechToText): Add autoload changes

f2eb224

Signed-off-by: Marcel Klehr <mklehr@gmx.net>


          chore(coding style): Run cs:fix

a9b5d1f

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr requested review from nickvergessen and juliusknorr

April 11, 2023 13:06

szaimen added the 2. developing label

szaimen added this to the Nextcloud 27 milestone


          chore(coding style): Run cs:fix

1833d93

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr changed the title ~~feat(SpeechToText): Add SpeechToText provider API~~ feat(SpeechToText): Add SpeechToText OCP provider API

juliusknorr reviewed

View reviewed changes

lib/public/SpeechToText/ISpeechToTextProvider.php Outdated Show resolved Hide resolved


          ISpeechToTextProvider#transcribeFile: Pass \OCP\Files\File instead of…

ef7ce88

… path

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr commented

View reviewed changes

lib/public/SpeechToText/ISpeechToTextProvider.php Show resolved Hide resolved

nickvergessen requested changes

View reviewed changes

lib/public/SpeechToText/ISpeechToTextManager.php Outdated Show resolved Hide resolved

lib/public/SpeechToText/ISpeechToTextManager.php Outdated Show resolved Hide resolved

lib/public/SpeechToText/Events/TranscriptionFinishedEvent.php Outdated Show resolved Hide resolved

lib/private/SpeechToText/TranscriptionJob.php Show resolved Hide resolved

lib/private/SpeechToText/SpeechToTextManager.php Outdated Show resolved Hide resolved

lib/private/SpeechToText/SpeechToTextManager.php Outdated Show resolved Hide resolved

marcelklehr added 3 commits

April 13, 2023 11:57


          ISpeechToTextManager: Take File as input, drop $context

176f1af

Signed-off-by: Marcel Klehr <mklehr@gmx.net>


          Split TranscriptionFinishedEvent into Successful and Failed events

a8d3fff

Signed-off-by: Marcel Klehr <mklehr@gmx.net>


          Add missing strict_types + author + copyright

865ebfa

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

nickvergessen requested changes

View reviewed changes

lib/private/SpeechToText/SpeechToTextManager.php Outdated Show resolved Hide resolved

lib/private/SpeechToText/TranscriptionJob.php Outdated Show resolved Hide resolved

lib/public/SpeechToText/Events/TranscriptionFailedEvent.php Outdated Show resolved Hide resolved

lib/public/SpeechToText/Events/TranscriptionSuccessfulEvent.php Show resolved Hide resolved

lib/public/SpeechToText/Events/AbstractTranscriptionEvent.php Outdated Show resolved Hide resolved


          Update lib/private/SpeechToText/SpeechToTextManager.php

ad66180

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

marcelklehr commented

View reviewed changes

lib/private/SpeechToText/SpeechToTextManager.php Outdated Show resolved Hide resolved

marcelklehr added 3 commits

April 17, 2023 14:57


          AbstractTranscriptionEvent: Add File param

71523b9

Signed-off-by: Marcel Klehr <mklehr@gmx.net>


          Transcription*Event: Add doc block

ad1a0d8

Signed-off-by: Marcel Klehr <mklehr@gmx.net>


          SpeechToTextManager: Deduplicate transcription jobs

3779cc3

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

nickvergessen reviewed

View reviewed changes

lib/private/SpeechToText/SpeechToTextManager.php Outdated Show resolved Hide resolved


          Update lib/private/SpeechToText/SpeechToTextManager.php

6e9f260

Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

nickvergessen approved these changes

View reviewed changes

nickvergessen added enhancement pending documentation labels

nickvergessen reviewed

View reviewed changes

lib/private/SpeechToText/SpeechToTextManager.php Outdated Show resolved Hide resolved

nickvergessen reviewed

View reviewed changes

lib/public/SpeechToText/ISpeechToTextManager.php Outdated Show resolved Hide resolved

nickvergessen reviewed

View reviewed changes

lib/public/SpeechToText/ISpeechToTextManager.php Outdated Show resolved Hide resolved

nickvergessen reviewed

View reviewed changes

lib/private/SpeechToText/SpeechToTextManager.php Show resolved Hide resolved


          Fix missing import

bef4cf0

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen added 3. to review and removed 2. developing labels

marcelklehr and others added 3 commits

April 18, 2023 15:24


          Update lib/private/SpeechToText/SpeechToTextManager.php

9649f91

Co-authored-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>


          Run cs:fix

ce651e5

Signed-off-by: Marcel Klehr <mklehr@gmx.net>


          TranscriptionJob: Ensure filesystem is setup before trying to retriev…

eb996cb

…e file

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

nickvergessen reviewed

View reviewed changes

lib/private/SpeechToText/SpeechToTextManager.php Outdated Show resolved Hide resolved


          TranscriptionJob: Add owner argument to simplify filesystem setup

a8b27c9

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

nickvergessen reviewed

View reviewed changes

lib/private/SpeechToText/SpeechToTextManager.php Outdated Show resolved Hide resolved

marcelklehr added 2 commits

April 19, 2023 12:35


          SpeechToTextManager#scheduleFileTranscription: Take context params an…

a2f5421

…d expose them on the Transcription*Events

Signed-off-by: Marcel Klehr <mklehr@gmx.net>


          Context params: Make userId nullable

fbcd275

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

nickvergessen reviewed

View reviewed changes

lib/public/SpeechToText/ISpeechToTextManager.php Outdated Show resolved Hide resolved


          Fix(docs): Fix parameter type in doc block

db9901a

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen approved these changes

View reviewed changes


          fix(autoloader): Rebuild

ab7b63d

Signed-off-by: Joas Schilling <coding@schilljs.com>

julien-nc self-requested a review

April 19, 2023 12:51

julien-nc approved these changes

View reviewed changes

Member Author

marcelklehr commented Apr 19, 2023

Documentation pending. Working on it right now.

marcelklehr mentioned this pull request

feat(SpeechToText): Add developer docs for OCP\SpeechToText nextcloud/documentation#10085

Merged

Member Author

marcelklehr commented Apr 19, 2023

Documentation pr: nextcloud/documentation#10085

nickvergessen merged commit fd473f8 into master

nickvergessen deleted the feature/speech-to-text branch

April 19, 2023 14:29

ChristophWurst removed the pending documentation label

Member Author

marcelklehr commented Apr 19, 2023

woop woop. thanks @nickvergessen for helping me with this!

Member

nickvergessen commented Apr 19, 2023

Don't forget to add an entry in #37039 referencing this PR and the documentation page

Member Author

marcelklehr commented Apr 19, 2023

Isn't #37039 only for (breaking) changes? I didn't know we also add additions there, that's also why I didn't add the translations API there. Will add this, though.

marcelklehr mentioned this pull request

Changes for developers & admins for Nextcloud 27 #37039

Closed

Member

nickvergessen commented Apr 19, 2023

that's also why I didn't add the translations API there.

Yeah I complained about this already.

No, it used to be breaking changes only, but now it's basically the OCP changelog.

marcelklehr mentioned this pull request

feat(BackgroundJobs): Allow preventing parallel runs for a job class #37835

Merged

4 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement