Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button text #37697

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Fix button text #37697

merged 1 commit into from
Apr 13, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Apr 13, 2023

Summary

Before After
image image

Checklist

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added the 3. to review Waiting for reviews label Apr 13, 2023
@Pytal Pytal added this to the Nextcloud 27 milestone Apr 13, 2023
@Pytal Pytal self-assigned this Apr 13, 2023
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhh that's a dirty one 🙈

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@nickvergessen
Copy link
Member

/backport to stable26

@Pytal
Copy link
Member Author

Pytal commented Apr 13, 2023

/backport to stable25

@nickvergessen
Copy link
Member

Only needed on versions where we backported the vue lib update that brought in the closing button, I think stable25?

@nextcloud nextcloud deleted a comment from Pytal Apr 13, 2023
@nextcloud nextcloud deleted a comment from Pytal Apr 13, 2023
@nextcloud nextcloud deleted a comment from Pytal Apr 13, 2023
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Apr 13, 2023

The backport to stable25 failed. Please do this backport manually.

Details
# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

#37720

@backportbot-nextcloud

This comment was marked as outdated.

@backportbot-nextcloud

This comment was marked as outdated.

@backportbot-nextcloud

This comment was marked as outdated.

@backportbot-nextcloud

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants