Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new file/folder labels #37929

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Create new file/folder labels #37929

merged 1 commit into from
Apr 27, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Apr 26, 2023 •
edited
Loading

Summary

Add labels for the submit buttons
image

TODO

  • Files view
  • Public files editable view

Related

Checklist

@Pytal Pytal added the 2. developing Work in progress label Apr 26, 2023
@Pytal Pytal self-assigned this Apr 26, 2023
@Pytal Pytal mentioned this pull request Apr 26, 2023
Closed
3 tasks
@Pytal Pytal force-pushed the enh/a11y-create-new-label branch from c731f22 to 71d84c6 Compare April 27, 2023 02:46
@Pytal Pytal changed the title [WIP] New file/folder menu labels Create new file/folder labels Apr 27, 2023
@Pytal Pytal mentioned this pull request Apr 27, 2023
Merged
4 tasks
@Pytal Pytal marked this pull request as ready for review April 27, 2023 02:55
@Pytal Pytal added this to the Nextcloud 27 milestone Apr 27, 2023
@Pytal Pytal added 3. to review Waiting for reviews feature: files accessibility and removed 2. developing Work in progress labels Apr 27, 2023
@Pytal
Copy link
Member Author

Pytal commented Apr 27, 2023

/compile amend /

@Pytal @nextcloud-command
Create new file/folder labels
966bc06 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the enh/a11y-create-new-label branch from 71d84c6 to 966bc06 Compare April 27, 2023 03:20
@juliusknorr
Copy link
Member

Failure unrelated

@juliusknorr juliusknorr merged commit 2646fd5 into master Apr 27, 2023
@juliusknorr juliusknorr deleted the enh/a11y-create-new-label branch April 27, 2023 07:06
@artonge
Copy link
Contributor

artonge commented Apr 27, 2023

This breaks master when no $actionLabel is set. Should we have a default value for it?

@juliusknorr juliusknorr mentioned this pull request Apr 27, 2023
Merged
@Pytal Pytal mentioned this pull request Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility feature: files
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
5 participants
@Pytal @juliusknorr @artonge @nickvergessen @skjnldsv