feat: Reword login form disabled warning #37949 #37953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
a team,
artonge,
skjnldsv and
Pytal
and removed request for
a team
skjnldsv
approved these changes
Apr 27, 2023
|
@moan0s please rebase this branch from master, run npm ci and npm run build and commit the changed files here. Then we can merge this. Thanks a lot! :) |
auto-merge was automatically disabled
April 27, 2023 14:07
Head branch was pushed to by a user without write access
|
I hope I did the rebase correctly, files should be okay |
Merged
szaimen
added
2. developing
Merged
szaimen
previously requested changes
May 19, 2023
szaimen
reviewed
May 19, 2023
szaimen
reviewed
May 19, 2023
Merged
|
I would also approve this change, any chance of merging it in the near future? |
susnux
force-pushed
the
reword-disabled-login-form
branch
from
b9a2e28 to
abbd844
Compare
susnux
approved these changes
Mar 17, 2024
susnux
added
bug
design
susnux
force-pushed
the
reword-disabled-login-form
branch
from
abbd844 to
654a2e6
Compare
Co-authored-by: Simon L. <szaimen@e.mail.de> Signed-off-by: Julian-Samuel Gebühr <julian-samuel@gebuehr.net>
Signed-off-by: Julian-Samuel Gebühr <julian-samuel@gebuehr.net>
susnux
force-pushed
the
reword-disabled-login-form
branch
from
654a2e6 to
d397dd6
Compare
|
Rebased - but I think drone does not work on forks? |
Merged
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rewords & restyles the warning used when the nextcloud login form is disabled
TODO
Checklist