Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] allow storing multiple mounts for the same rootid in the mount cache #38022

Merged
merged 3 commits into from
Jun 15, 2023

Commits on May 31, 2023

  1. allow storing multiple mounts for the same rootid in the mount cache

    currently `[$userId, $rootId]` is used as the unique key for storing mounts in the mount cache,
    however there are cases where the same rootid is mounted in multiple places for a user which currently leads to not all of those mounts being added to the cache.
    
    Previously this didn't matter as the mount cache was only used to list users with access to a specific file, so a user having access to the file multiple times didn' change anything.
    
    With 24 the mount cache is used for more cases and multiple mounts for the same id becomes relevant.
    While I think there isn't a real negative effect atm besides missing the optimized path we should ensure that the mounts are properly listed
    
    Signed-off-by: Robin Appelman <robin@icewind.nl>
    icewind1991 committed May 31, 2023
    Configuration menu
    Copy the full SHA
    0b40b11 View commit details
    Browse the repository at this point in the history
  2. add new index in repair step instead of on-migrate

    Signed-off-by: Robin Appelman <robin@icewind.nl>
    icewind1991 committed May 31, 2023
    Configuration menu
    Copy the full SHA
    b9f4723 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. ci: undo version.php change to avoid conflict in release PR

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    blizzz authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    370cfb2 View commit details
    Browse the repository at this point in the history