Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort tags by name #38067

Merged
merged 2 commits into from
May 11, 2023
Merged

fix: sort tags by name #38067

merged 2 commits into from
May 11, 2023

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented May 4, 2023

Alternative to #38066

@tobiasKaminsky please test, i did only superficially.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added the 3. to review Waiting for reviews label May 4, 2023
@blizzz blizzz added this to the Nextcloud 27 milestone May 4, 2023
@blizzz blizzz requested review from skjnldsv, a team, ArtificialOwl and nfebe and removed request for a team May 4, 2023 11:22
@blizzz blizzz marked this pull request as ready for review May 4, 2023 11:22
@blizzz blizzz mentioned this pull request May 4, 2023
4 tasks
@blizzz blizzz added bug 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 4, 2023
This was referenced May 9, 2023
@tobiasKaminsky
Copy link
Member

Tested and works, api wise.

come-nc
come-nc previously requested changes May 9, 2023
apps/dav/lib/SystemTag/SystemTagPlugin.php Outdated Show resolved Hide resolved
@tobiasKaminsky
Copy link
Member

When adding a tag "0123", then it first is shown correctly.
image

But on page refresh it is like this:
image

Copy link
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment about "0123"

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz dismissed stale reviews from come-nc and tobiasKaminsky May 10, 2023 17:18

Resolved

@blizzz
Copy link
Member Author

blizzz commented May 10, 2023

@tobiasKaminsky I can reproduce this behaviour with current master, so these changes are not causing it. Please open a separate issue.

@blizzz blizzz enabled auto-merge May 10, 2023 17:21
@blizzz blizzz disabled auto-merge May 11, 2023 07:53
@blizzz blizzz merged commit 2d41f0c into master May 11, 2023
@blizzz blizzz deleted the fix/noid/sortTags branch May 11, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants