feat(carddav): Map user's additional emails into the SAB card #38073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added
enhancement
3. to review
ChristophWurst
requested review from
blizzz,
tcitworld,
miaulalala,
hamza221 and
JohannesGGE
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -44,7 +46,13 @@ | |||
| } | |||
|
|
|||
| public function createCardFromUser(IUser $user): ?VCard { | |||
| $userProperties = $this->accountManager->getAccount($user)->getProperties(); | |||
| $account = $this->accountManager->getAccount($user); | |||
| $userProperties = $account->getProperties(); | |||
Check notice
Code scanning / Psalm
DeprecatedMethod
JohannesGGE
approved these changes
May 4, 2023
miaulalala
approved these changes
May 4, 2023
ChristophWurst
added
4. to release
ChristophWurst
deleted the
feat/caldav/map-additional-emails-system-addres-book
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The system address book (SAB) only contains the user's primary email address. With this change additional email addresses get saved to the card as well.
Right now only additional email addresses set to federated or published are saved. With #38048 local ones will be saved too.
Checklist