Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version check for ancient libxml version #38077

Merged
merged 1 commit into from
May 5, 2023

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented May 4, 2023

Summary

New error with psalm 5.

With LIBXML_LOADED_VERSION I get Cannot perform a numeric operation with a non-numeric type '21004-GITv2.10.4'.
Looking at https://www.php.net/manual/en/libxml.constants.php it's not even documented...

EDIT: This version is so old that we can just remove this check.

Checklist

@provokateurin provokateurin requested review from a team, ArtificialOwl, icewind1991 and nfebe and removed request for a team May 4, 2023 14:44
@szaimen szaimen added the 3. to review Waiting for reviews label May 4, 2023
@szaimen szaimen added this to the Nextcloud 27 milestone May 4, 2023
@provokateurin provokateurin changed the title Use LIBXML_VERSION instead of LIBXML_LOADED_VERSION Use LIBXML_VERSION and LIBXML_DOTTED_VERSION for checking libxml version May 5, 2023
@provokateurin
Copy link
Member Author

Looking at the code I was able to make it even easier since the version was used to parse and format it, but there is already a variable for the formatted version.

@nickvergessen
Copy link
Member

@kesselb
Copy link
Contributor

kesselb commented May 5, 2023

Good finding 👍

I think it should also work to remove the check for libxml 2.7.0.
It was released in 2008 (https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.7.4) so everyone should have it by now ;)

@provokateurin
Copy link
Member Author

It was released in 2008

Haha ok then it's even easier :D

@provokateurin provokateurin changed the title Use LIBXML_VERSION and LIBXML_DOTTED_VERSION for checking libxml version Remove version check for ancient libxml version May 5, 2023
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 5, 2023
@provokateurin provokateurin enabled auto-merge May 5, 2023 11:29
Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin provokateurin merged commit c40d1b7 into master May 5, 2023
@provokateurin provokateurin deleted the fix/libxml-version branch May 5, 2023 19:44
This was referenced May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants