-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove version check for ancient libxml version #38077
Conversation
edc8dcb
to
9a26bc1
Compare
Looking at the code I was able to make it even easier since the version was used to parse and format it, but there is already a variable for the formatted version. |
https://github.com/php/php-src/blob/master/ext/libxml/libxml.c#LL45C13-L45C34 hmm strange it's missing from the docs |
Good finding 👍 I think it should also work to remove the check for libxml 2.7.0. |
Haha ok then it's even easier :D |
9a26bc1
to
009c396
Compare
Signed-off-by: jld3103 <jld3103yt@gmail.com>
009c396
to
04d8402
Compare
Summary
New error with psalm 5.
With
LIBXML_LOADED_VERSION
I getCannot perform a numeric operation with a non-numeric type '21004-GITv2.10.4'
.Looking at https://www.php.net/manual/en/libxml.constants.php it's not even documented...
EDIT: This version is so old that we can just remove this check.
Checklist