Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Share Expire After N Days width #38101

Merged

Conversation

Jerome-Herbinet
Copy link
Member

@Jerome-Herbinet Jerome-Herbinet commented May 5, 2023

Box will inherit the same size of other input boxes on that page.

Before

2023-05-05_15-02

After

image

Checklist

@solracsf

This comment was marked as resolved.

@Jerome-Herbinet

This comment was marked as resolved.

@Jerome-Herbinet

This comment was marked as resolved.

@solracsf

This comment was marked as resolved.

@Jerome-Herbinet

This comment was marked as resolved.

@solracsf
Copy link
Member

solracsf commented May 5, 2023

/backport to stable26

@solracsf
Copy link
Member

solracsf commented May 5, 2023

/backport to stable25

@solracsf solracsf added design Design, UI, UX, etc. 3. to review Waiting for reviews labels May 5, 2023
@solracsf solracsf requested a review from szaimen May 5, 2023 14:24
@solracsf solracsf added this to the Nextcloud 27 milestone May 5, 2023
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didn test

This was referenced May 9, 2023
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
@szaimen szaimen force-pushed the Jerome-Herbinet-share-expire-after-n-days-width-patch-1 branch from bcfa004 to 5357b08 Compare May 16, 2023 09:46
@szaimen
Copy link
Contributor

szaimen commented May 16, 2023

/compile amend /

@szaimen szaimen enabled auto-merge May 16, 2023 09:46
@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 16, 2023
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the Jerome-Herbinet-share-expire-after-n-days-width-patch-1 branch from 5357b08 to 8620640 Compare May 16, 2023 14:22
@szaimen szaimen disabled auto-merge May 16, 2023 17:28
@szaimen szaimen merged commit 10ceae3 into master May 16, 2023
@szaimen szaimen deleted the Jerome-Herbinet-share-expire-after-n-days-width-patch-1 branch May 16, 2023 17:29
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@blizzz blizzz mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants