Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hidden labels for inputs while editing user row #38144

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions apps/settings/src/components/UserList/UserRow.vue
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
<form :class="{'icon-loading-small': loading.displayName}"
class="displayName"
@submit.prevent="updateDisplayName">
<label class="hidden-visually" :for="'displayName'+user.id+rand">{{ t('settings', 'Edit display name') }}</label>
<input :id="'displayName'+user.id+rand"
ref="displayName"
:disabled="loading.displayName||loading.all"
Expand All @@ -102,6 +103,7 @@
:class="{'icon-loading-small': loading.password}"
class="password"
@submit.prevent="updatePassword">
<label class="hidden-visually" :for="'password'+user.id+rand">{{ t('settings', 'Add new password') }}</label>
<input :id="'password'+user.id+rand"
ref="password"
:disabled="loading.password || loading.all"
Expand All @@ -121,6 +123,7 @@
<form :class="{'icon-loading-small': loading.mailAddress}"
class="mailAddress"
@submit.prevent="updateEmail">
<label class="hidden-visually" :for="'mailAddress'+user.id+rand">{{ t('settings', 'Add new email address') }}</label>
<input :id="'mailAddress'+user.id+rand"
ref="mailAddress"
:disabled="loading.mailAddress||loading.all"
Expand All @@ -134,7 +137,9 @@
<input class="icon-confirm" type="submit" value="">
</form>
<div :class="{'icon-loading-small': loading.groups}" class="groups">
<NcMultiselect :close-on-select="false"
<label class="hidden-visually" :for="'groups'+user.id+rand">{{ t('settings', 'Add user to group') }}</label>
<NcMultiselect :id="'groups'+user.id+rand"
:close-on-select="false"
:disabled="loading.groups||loading.all"
:limit="2"
:multiple="true"
Expand All @@ -156,7 +161,9 @@
<div v-if="subAdminsGroups.length>0 && settings.isAdmin"
:class="{'icon-loading-small': loading.subadmins}"
class="subadmins">
<NcMultiselect :close-on-select="false"
<label class="hidden-visually" :for="'subadmins'+user.id+rand">{{ t('settings', 'Set user as admin for') }}</label>
<NcMultiselect :id="'subadmins'+user.id+rand"
:close-on-select="false"
:disabled="loading.subadmins||loading.all"
:limit="2"
:multiple="true"
Expand All @@ -175,7 +182,9 @@
<div :title="usedSpace"
:class="{'icon-loading-small': loading.quota}"
class="quota">
<NcMultiselect :allow-empty="false"
<label class="hidden-visually" :for="'quota'+user.id+rand">{{ t('settings', 'Select user quota') }}</label>
<NcMultiselect :id="'quota'+user.id+rand"
:allow-empty="false"
:disabled="loading.quota||loading.all"
:options="quotaOptions"
:placeholder="t('settings', 'Select user quota')"
Expand All @@ -191,7 +200,9 @@
<div v-if="showConfig.showLanguages"
:class="{'icon-loading-small': loading.languages}"
class="languages">
<NcMultiselect :allow-empty="false"
<label class="hidden-visually" :for="'language'+user.id+rand">{{ t('settings', 'Set the language') }}</label>
<NcMultiselect :id="'language'+user.id+rand"
:allow-empty="false"
:disabled="loading.languages||loading.all"
:options="languages"
:placeholder="t('settings', 'No language set')"
Expand Down
4 changes: 2 additions & 2 deletions dist/settings-users-8351.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/settings-users-8351.js.map

Large diffs are not rendered by default.

Loading