Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Rename setting 'sendEventRemindersToSharedGroupMembers' -> 'sendEventRemindersToSharedUsers'." #38177

Closed
wants to merge 1 commit into from
Closed

Revert "Rename setting 'sendEventRemindersToSharedGroupMembers' -> 'sendEventRemindersToSharedUsers'." #38177

wants to merge 1 commit into from

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented May 10, 2023

Reverts #31660

@szaimen szaimen added the 3. to review Waiting for reviews label May 10, 2023
@szaimen szaimen added this to the Nextcloud 27 milestone May 10, 2023
@szaimen szaimen mentioned this pull request May 10, 2023
Merged
@blizzz blizzz mentioned this pull request May 12, 2023
Merged
@szaimen
Copy link
Contributor Author

szaimen commented May 16, 2023

Merge?

@blizzz blizzz mentioned this pull request May 17, 2023
Merged
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 22, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@susnux
Copy link
Contributor

susnux commented Aug 14, 2023

Whats the state here?

@szaimen
Copy link
Contributor Author

szaimen commented Aug 14, 2023

Whats the state here?

I would close it...

@szaimen szaimen closed this Aug 17, 2023
@szaimen szaimen deleted the revert-31660-pr/rename-sendEventRemindersToSharedGroupMembers-to-sendEventRemindersToSharedUsers branch August 17, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
5 participants
@szaimen @susnux @ChristophWurst @miaulalala @blizzz