Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(middleware): Also abort the request when reaching max delay in af… #38274

Merged
merged 1 commit into from
May 16, 2023
Merged

fix(middleware): Also abort the request when reaching max delay in af… #38274

merged 1 commit into from
May 16, 2023

Conversation

nickvergessen
Copy link
Member

…terController

Best reviewed with ?w=1

@nickvergessen
fix(middleware): Also abort the request when reaching max delay in af…
3a6bc7a 
…terController

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels May 15, 2023
@nickvergessen nickvergessen added this to the Nextcloud 27 milestone May 15, 2023
@nickvergessen nickvergessen self-assigned this May 15, 2023
@nickvergessen nickvergessen mentioned this pull request May 15, 2023
Merged
@nickvergessen nickvergessen requested review from come-nc and blizzz May 15, 2023 14:26
This was referenced May 15, 2023
Merged
Merged
Merged
Merged
Merged
come-nc
come-nc reviewed May 15, 2023
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the diff much shorter in backports?

come-nc
come-nc approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, it’s because attribute are supported on master and not on previous versions

@nickvergessen nickvergessen merged commit 5e02def into master May 16, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/reach-max-delay-in-afterController branch May 16, 2023 09:07
@blizzz blizzz mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@miaulalala miaulalala miaulalala approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @miaulalala @come-nc