feat: Add occ user:user:sync-account-data for updating oc_accounts information from user backends #38298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
enh/occ-sync-account-data
branch
from
ad1f161 to
bd83841
Compare
juliusknorr
requested review from
a team,
ArtificialOwl,
ChristophWurst,
blizzz and
icewind1991
and removed request for
a team
juliusknorr
added
bug
3. to review
ChristophWurst
approved these changes
Jun 6, 2023
…tion from user backends This can be useful in cases where the state between user backend and oc_accounts has become inconsistent. Usually the account data is updated once the change on the user backend is detected. Potential leftovers from older bugs (nextcloud/user_saml#582) might though never get updated. This could lead to the contacts menu never showing the correct display name. The contacts menu is read from the system address book, which is only updated from oc_accounts. Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
enh/occ-sync-account-data
branch
from
49cf2a6 to
095b43f
Compare
miaulalala
approved these changes
Aug 16, 2023
Contributor
|
@ChristophWurst @miaulalala can we backport to 27? |
Member
|
Is it critical? I'd usually vote against backporting features |
Contributor
|
/backport to stable27 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This can be useful in cases where the state between user backend and oc_accounts has become inconsistent.
Usually the account data is updated once the change on the user backend is detected. Potential leftovers from older bugs
(nextcloud/user_saml#582) might though never get updated. This could lead to the contacts menu never showing the correct display name. The contacts menu is read from the system address book, which is only updated from oc_accounts.
Checklist