fix(search): fix load more

[skjnldsv]

Fix #35558
Regression from #34100

When search for files, clicking the "load more" button, changes the URL and the legacy files list triggers a navigation change.
I fixed the url change and added a sanity check in the legacy url change detection to potentially mitigate other unseen issues.

[skjnldsv]

/backport to stable26

[skjnldsv]

/backport to stable25

[szaimen]

Tested and works however one small remark

[szaimen]

see above

[backportbot-nextcloud]

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[szaimen]

/backport to stable25

[ostasevych]

Hi! Please, suggest quick and dirty hack how to get these changes on my personal prod site?

[skjnldsv]

Hi! Please, suggest quick and dirty hack how to get these changes on my personal prod site?

You can download the patch and manually try to apply it from either the stable25 or stable26 branch

• [stable25] fix(search): fix load more #38325
• [stable26] fix(search): fix load more #38318

https://coderwall.com/p/6aw72a/creating-patch-from-github-pull-request

[t-markmann]

Hi! Please, suggest quick and dirty hack how to get these changes on my personal prod site?

You can download the patch and manually try to apply it from either the stable25 or stable26 branch

* [[stable25] fix(search): fix load more #38325](https://github.com/nextcloud/server/pull/38325)

* [[stable26] fix(search): fix load more #38318](https://github.com/nextcloud/server/pull/38318)

https://coderwall.com/p/6aw72a/creating-patch-from-github-pull-request

Unfortunately this only seems to work, if your (production) NC instance is a git repo.
If you execute the .patch in a normally installed NC directory, this will be returned: fatal: not a git repository (or any parent up to mount point /)

Solution might be "git init" and so on. But then your NC dir ist not clean and upgradeable anymore, I think.

A more practicable solution: download the 3 (non-src) files and replace the old ones.
These commands will do (if you adjust your www-data user and the nc path):

NCBASE=/var/www/nextcloud

cd ${NCBASE}/apps/files/js
sudo -u www-data curl -O https://raw.githubusercontent.com/nextcloud/server/b4d7f56b7adb5f74b243f3520b774451158c57d5/apps/files/js/app.js

cd ${NCBASE}/dist
sudo -u www-data curl -O https://raw.githubusercontent.com/nextcloud/server/b4d7f56b7adb5f74b243f3520b774451158c57d5/dist/core-unified-search.js

sudo -u www-data curl -O https://raw.githubusercontent.com/nextcloud/server/b4d7f56b7adb5f74b243f3520b774451158c57d5/dist/core-unified-search.js.map

[ostasevych]

Hi! Please, suggest quick and dirty hack how to get these changes on my personal prod site?

You can download the patch and manually try to apply it from either the stable25 or stable26 branch

* [[stable25] fix(search): fix load more #38325](https://github.com/nextcloud/server/pull/38325)

* [[stable26] fix(search): fix load more #38318](https://github.com/nextcloud/server/pull/38318)

https://coderwall.com/p/6aw72a/creating-patch-from-github-pull-request

Unfortunately this only seems to work, if your (production) NC instance is a git repo. If you execute the .patch in a normally installed NC directory, this will be returned: fatal: not a git repository (or any parent up to mount point /)

Solution might be "git init" and so on. But then your NC dir ist not clean and upgradeable anymore, I think.

A more practicable solution: download the 3 (non-src) files and replace the old ones. These commands will do (if you adjust your www-data user and the nc path):

NCBASE=/var/www/nextcloud

cd ${NCBASE}/apps/files/js
sudo -u www-data curl -O https://raw.githubusercontent.com/nextcloud/server/b4d7f56b7adb5f74b243f3520b774451158c57d5/apps/files/js/app.js

cd ${NCBASE}/dist
sudo -u www-data curl -O https://raw.githubusercontent.com/nextcloud/server/b4d7f56b7adb5f74b243f3520b774451158c57d5/dist/core-unified-search.js

sudo -u www-data curl -O https://raw.githubusercontent.com/nextcloud/server/b4d7f56b7adb5f74b243f3520b774451158c57d5/dist/core-unified-search.js.map

Be careful by applying it:

By replacing these 3 files I am obtaining empty home folder with this error in the logs:
TypeError: OCA\Files\Service\TagService::__construct(): Argument #4 ($homeFolder) must be of type OCP\Files\Folder, null given, called in /var/www/html/nextcloud/apps/files/lib/AppInfo/Application.php on line 111 :(

[t-markmann]

Hm, I'm running a NC 25.0.5.1
Works fine here...

[ostasevych]

Hm, I'm running a NC 25.0.5.1 Works fine here...

With 26.0.1 it goes not so well. I haven't to revert back.
UPD: Well, the above mentioned error message in the logs, it seems is not connected with this behaviour, as I found it in the earlier logs....

[t-markmann]

The Files for 25 / 26 are different.
Try these for NC26:

NCBASE=/var/www/nextcloud

cd ${NCBASE}/apps/files/js
sudo -u www-data curl -O https://raw.githubusercontent.com/nextcloud/server/6da7e66dc19696f991968bb36fba0ee3a3982078/apps/files/js/app.js

cd ${NCBASE}/dist
sudo -u www-data curl -O https://raw.githubusercontent.com/nextcloud/server/6da7e66dc19696f991968bb36fba0ee3a3982078/dist/core-unified-search.js

sudo -u www-data curl -O https://raw.githubusercontent.com/nextcloud/server/6da7e66dc19696f991968bb36fba0ee3a3982078/dist/core-unified-search.js.map

[ostasevych]

The Files for 25 / 26 are different. Try these for NC26:

NCBASE=/var/www/nextcloud

cd ${NCBASE}/apps/files/js
sudo -u www-data curl -O https://raw.githubusercontent.com/nextcloud/server/6da7e66dc19696f991968bb36fba0ee3a3982078/apps/files/js/app.js

cd ${NCBASE}/dist
sudo -u www-data curl -O https://raw.githubusercontent.com/nextcloud/server/6da7e66dc19696f991968bb36fba0ee3a3982078/dist/core-unified-search.js

sudo -u www-data curl -O https://raw.githubusercontent.com/nextcloud/server/6da7e66dc19696f991968bb36fba0ee3a3982078/dist/core-unified-search.js.map

Thanks. That works fine!

[skjnldsv]

Unfortunately this only seems to work, if your (production) NC instance is a git repo.

Yeah, this is not for production.
If you don't know what you're doing, I suggest to not experiment with your production services :)