Wrap doctrine exceptions on IQueryBuilder::execute #38439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/noid/wrap-execute-exception
branch
from
edbb095 to
66fdd03
Compare
juliusknorr
changed the title
|
I think I did that but had to revert. This is tricky. |
|
Ok, then let me close this as we're also pushing the backported fix to master with #38478 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the method is deprecated it is still used in tons of places especially in server, and the annotation for throwing a
OCP\DB\Exceptionwas wrong for a long time. This PR aims to wrap the\Doctrine\DBAL\Exceptionthat is actually thrown in aOCP\DB\Exceptionas it is already done for executeQuery and executeStatement.Since this is bringing the implementation up to date with the alerady existing php doc comments I wouldn't consider this breaking but I could imagine all kind of issues showing up, therefore I opened as a backport fix for 27 and below #38440
Let's see what CI thinks about this