[stable26] redis: use atomic operations everywhere #38539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
This removes a lot of acrobatics in the code and does each operation atomically using a lua script. This also reduces several round trips to the server, and the scripts are compiled and cached server-side. Notably, since all operations work only on a single key (except clear, which is broken anyway and shouldn't be used), they will continue to function and be atomic for Redis cluster. Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: Robin Appelman <robin@icewind.nl>
backportbot-nextcloud
bot
added
feature: caching
backportbot-nextcloud
bot
requested review from
CarlSchwan,
icewind1991,
juliusknorr and
pulsejet
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
ChristophWurst
force-pushed
the
backport/37758/stable26
branch
from
fa53646 to
119e52f
Compare
ChristophWurst
approved these changes
May 31, 2023
|
/backport to stable25 |
juliusknorr
approved these changes
Jun 1, 2023
|
Failures all look unrelated. |
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #37758