Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Store encrypted OAuth2 client secrets #38709

Merged
merged 2 commits into from
Jun 14, 2023
Merged

[stable25] Store encrypted OAuth2 client secrets #38709

merged 2 commits into from
Jun 14, 2023

Conversation

julien-nc
Copy link
Member

@julien-nc julien-nc commented Jun 8, 2023 •
edited
Loading

Manual backport of #38398 and #38701

I kept the original migration version so it does not reflect the actual app version.

@julien-nc julien-nc added 3. to review Waiting for reviews security labels Jun 8, 2023
@julien-nc julien-nc added this to the Nextcloud 25.0.8 milestone Jun 8, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 8, 2023
View reviewed changes
apps/oauth2/lib/Migration/Version011601Date20230522143227.php
return null;
}

public function postSchemaChange(IOutput $output, Closure $schemaClosure, array $options) {

Check notice

Code scanning / Psalm

MissingReturnType

Method OCA\OAuth2\Migration\Version011601Date20230522143227::postSchemaChange does not have a return type, expecting void
@julien-nc julien-nc force-pushed the backport/38398/stable25 branch 2 times, most recently from 8eedc06 to 60aa0d2 Compare June 9, 2023 08:24
@julien-nc julien-nc requested review from kesselb, szaimen, a team, ArtificialOwl, icewind1991 and Fenn-CS and removed request for a team June 9, 2023 08:25
szaimen
szaimen approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@blizzz blizzz mentioned this pull request Jun 12, 2023
Merged
ChristophWurst
ChristophWurst requested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#38398 (comment)

@julien-nc julien-nc force-pushed the backport/38398/stable25 branch 2 times, most recently from 88ee6d8 to efa52d3 Compare June 12, 2023 15:13
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 13, 2023
@julien-nc
encrypt oauth2 client secrets
aa9fa95 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
add test that inserts a long oauth client secret
7f7f824 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@blizzz blizzz merged commit a330459 into stable25 Jun 14, 2023
@blizzz blizzz deleted the backport/38398/stable25 branch June 14, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@szaimen szaimen szaimen approved these changes

@kesselb kesselb Awaiting requested review from kesselb

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish security
Projects
None yet
Milestone
Nextcloud 25.0.8
Development

Successfully merging this pull request may close these issues.
4 participants
@julien-nc @ChristophWurst @szaimen @blizzz