Refactors lib/private/FullTextSearch #38996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
a team,
ArtificialOwl,
icewind1991 and
Fenn-CS
and removed request for
a team
fsamapoor
commented
Jun 27, 2023
icewind1991
approved these changes
Jul 4, 2023
fsamapoor
force-pushed
the
refactor_lib_private_fulltextsearch
branch
from
629e918
to
b920fb1
Compare
come-nc
requested changes
Oct 5, 2023
Fenn-CS
approved these changes
Oct 9, 2023
fsamapoor
force-pushed
the
refactor_lib_private_fulltextsearch
branch
2 times, most recently
from
93c565c
to
217101a
Compare
Merged
Merged
fsamapoor
force-pushed
the
refactor_lib_private_fulltextsearch
branch
from
217101a
to
a7beea1
Compare
|
@come-nc Anything I need to change in this PR? I believe the integration workflow may have timed out. |
come-nc
reviewed
Nov 7, 2023
fsamapoor
force-pushed
the
refactor_lib_private_fulltextsearch
branch
from
a7beea1
to
e03294a
Compare
come-nc
approved these changes
Nov 9, 2023
|
@fsamapoor autoloaders are not up to date, probably because of the new Exception class, please run build/autoloaderchecker.sh and commit the files with new classes. |
fsamapoor
force-pushed
the
refactor_lib_private_fulltextsearch
branch
from
e03294a
to
4312e2d
Compare
fsamapoor
requested review from
ChristophWurst,
miaulalala,
nickvergessen and
st3iny
as code owners
@come-nc Done. |
fsamapoor
force-pushed
the
refactor_lib_private_fulltextsearch
branch
from
4312e2d
to
82d2ddf
Compare
lib/public/FullTextSearch/Exceptions/FullTextSearchIndexNotAvailableException.php
Show resolved
Hide resolved
fsamapoor
commented
Nov 9, 2023
ChristophWurst
approved these changes
Nov 9, 2023
fsamapoor
force-pushed
the
refactor_lib_private_fulltextsearch
branch
from
82d2ddf
to
05e043b
Compare
fsamapoor
force-pushed
the
refactor_lib_private_fulltextsearch
branch
from
05e043b
to
ece1e78
Compare
fsamapoor
force-pushed
the
refactor_lib_private_fulltextsearch
branch
from
ece1e78
to
1e76d5e
Compare
fsamapoor
force-pushed
the
refactor_lib_private_fulltextsearch
branch
from
1e76d5e
to
144e809
Compare
Mainly using PHP8's constructor property promotion. Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com> Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com> Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
fsamapoor
force-pushed
the
refactor_lib_private_fulltextsearch
branch
from
144e809
to
cdf9d94
Compare
skjnldsv
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following previous PRs taking advantage of PHP8's constructor property promotion in
/core/namespace, I have also made the required adjustments to the classes in/lib/private/FullTextSearchnamespace.The improvements in this PRs include: