Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(a11y): Users table #39050

Merged
merged 7 commits into from
Jul 13, 2023
Merged

enh(a11y): Users table #39050

merged 7 commits into from
Jul 13, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jun 29, 2023 •
edited
Loading

Summary

Screenshot
Before image
After image
Before image
After image

TODO

  • Tests

Checklist

@Pytal Pytal added the 2. developing Work in progress label Jun 29, 2023
@Pytal Pytal added this to the Nextcloud 28 milestone Jun 29, 2023
@Pytal Pytal self-assigned this Jun 29, 2023
@Pytal Pytal mentioned this pull request Jun 29, 2023
Closed
2 tasks
@Pytal Pytal force-pushed the enh/a11y-users-table branch 5 times, most recently from 52e7aca to 9294f73 Compare July 6, 2023 01:13
@Pytal Pytal changed the title [WIP] Users table enh(a11y): Users table Jul 6, 2023
@Pytal Pytal marked this pull request as ready for review July 6, 2023 01:27
@Pytal Pytal mentioned this pull request Jul 6, 2023
Closed
4 tasks
@Pytal Pytal force-pushed the enh/a11y-users-table branch from 9294f73 to 8b10788 Compare July 8, 2023 00:30
@Pytal Pytal force-pushed the enh/a11y-users-table branch from 8b10788 to 363463a Compare July 12, 2023 05:23
JuliaKirschenheuter
JuliaKirschenheuter approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Jul 12, 2023
Closed
9 tasks
@Pytal
enh(a11y): Users table
cbfe0c6 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal added 4 commits July 12, 2023 17:30
@Pytal
chore: Compile assets
821fcc6 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(cypress): users_disable
957dbee 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(cypress): users_modify
b65eb0c 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(cypress): users
ce99dd9 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/a11y-users-table branch from 363463a to 60c55a0 Compare July 13, 2023 00:35
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 13, 2023
Pytal added 2 commits July 12, 2023 21:35
@Pytal
fix(acceptance): UsersSettingsContext
8faa1a4 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
test(settings): Users table
faf2b23 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/a11y-users-table branch from 60c55a0 to faf2b23 Compare July 13, 2023 04:36
@Pytal Pytal merged commit 41540ad into master Jul 13, 2023
@Pytal Pytal deleted the enh/a11y-users-table branch July 13, 2023 05:29
@Pytal Pytal linked an issue Jul 18, 2023 that may be closed by this pull request
[BITV] 9.1.3.1e/8.1 - The user table represents a grid element and should be implemented as such. (1) #36921
Closed
2 tasks
@nickvergessen nickvergessen mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge artonge approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@susnux susnux susnux approved these changes

@nfebe nfebe Awaiting requested review from nfebe

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility enhancement feature: users and groups
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

[BITV] 9.1.3.1e/8.1 - The user table represents a grid element and should be implemented as such. (1)
5 participants
@Pytal @susnux @JuliaKirschenheuter @artonge @skjnldsv